Add PHONY for variable targets#1725
Add PHONY for variable targets#1725openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
The Makefile targets that are variables, weren't set as PHONY. That means their recipes weren't run when the generated files already existed. This could cause issues, such as with an out of date controller-gen. Signed-off-by: James Slagle <jslagle@redhat.com>
bshephar
left a comment
bshephar
left a comment
There was a problem hiding this comment.
Sounds reasonable to me, fwiw.
|
@bshephar: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thank you sir, hope you are well. Happy New Year! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, oliashish, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit dccd26a
into
openstack-k8s-operators:main
3 participants
The Makefile targets that are variables, weren't set as PHONY. That
means their recipes weren't run when the generated files already
existed. This could cause issues, such as with an out of date
controller-gen.
Signed-off-by: James Slagle jslagle@redhat.com